[PATCH] D121848: [scudo] Remove unused header includes and fix declarations

Dominic Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 18 12:58:20 PDT 2022


ddcc added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/vector.h:14
 
-#include <string.h>
-
----------------
vitalybuka wrote:
> ddcc wrote:
> > vitalybuka wrote:
> > > it's used on :46
> > `common.h` includes `string.h` already, so this additional include is unnecessary. We have some custom library paths in our build system, so I needed to go through each include.
> Unless there is a strong reason to do so, I am for IWYU.
> 
Ok, I've dropped the header removals from this patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121848/new/

https://reviews.llvm.org/D121848



More information about the llvm-commits mailing list