[PATCH] D121787: [VectorCombine] Insert addrspacecast when crossing address space boundaries

[Artem Belevich via Phabricator via llvm-commits]

tra added a comment.

In D121787#3388739 <https://reviews.llvm.org/D121787#3388739>, @frasercrmck wrote:

>> I don't follow. Performance in what sense?
>
> I'm not sure exactly what, just picking up on @tra's comment and previous fix (why we didn't just use `addrspacecast` before). But like I said, if we find ourselves with a different AS to the original, musn't we have an addrspace cast in the original IR, so we're not introducing a new one? Therefore I don't think the cost of `addrspacecast` is important, and we already take the cost of the scalar-vs-vector load into account.

My comment was about relaxing the AS mismatch check and allowing different AS with no-cost ASC. With that check gone, my suggestion is now irrelevant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121787/new/

https://reviews.llvm.org/D121787