[PATCH] D121996: [NVPTX][tests] Do not run tests that require direct object generation

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 18 11:16:16 PDT 2022


tra added a comment.

In D121996#3392197 <https://reviews.llvm.org/D121996#3392197>, @nigelp-xmos wrote:

> The code LGTM. When object-emission was reintroduced in D98508 <https://reviews.llvm.org/D98508>, there was some discussion on whether XCore ought to use this feature, or provide an integrated assembler instead. Sorry I don't know NVPTX: is NVPTX different because it generates assembly as its natural output, and binary does not make sense? Or could it have an integrated assembler at some point?

NVPTX only generates assembly. It is not going to have native code generation any time soon. It it did, we'd have multiple native back-ends. In other words, LGTM as far as NVPTX back-end is concerned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121996/new/

https://reviews.llvm.org/D121996



More information about the llvm-commits mailing list