[PATCH] D121993: Mark derived destructors as `override`
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 18 09:10:46 PDT 2022
dblaikie added inline comments.
================
Comment at: llvm/include/llvm/Analysis/ScalarEvolution.h:227
SCEVPredicateKind Kind;
- ~SCEVPredicate() = default;
+ virtual ~SCEVPredicate() = default;
SCEVPredicate(const SCEVPredicate &) = default;
----------------
Why is this being made virtual?
================
Comment at: llvm/include/llvm/IR/IRBuilder.h:80
public:
- virtual ~IRBuilderCallbackInserter();
+ virtual ~IRBuilderCallbackInserter() override;
----------------
Please drop virtual when adding override.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121993/new/
https://reviews.llvm.org/D121993
More information about the llvm-commits
mailing list