[PATCH] D121654: [RISCV] Ensure PseudoLA* can be hoisted

[Kamau Bridgeman via Phabricator via llvm-commits]

kamaub added a comment.

In D121654#3391141 <https://reviews.llvm.org/D121654#3391141>, @jrtc27 wrote:

> In D121654#3391091 <https://reviews.llvm.org/D121654#3391091>, @kamaub wrote:
>
>> In D121654#3390916 <https://reviews.llvm.org/D121654#3390916>, @jrtc27 wrote:
>>
>>> Does:
>>>
>>>   diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
>>>   index f52965dab759..299c68da7c2f 100644
>>>   --- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
>>>   +++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
>>>   @@ -3769,6 +3769,15 @@ SDValue RISCVTargetLowering::getAddr(NodeTy *N, SelectionDAG &DAG,
>>>      }
>>>    }
>>>    
>>>   +template SDValue RISCVTargetLowering::getAddr<GlobalAddressSDNode>(
>>>   +    GlobalAddressSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
>>>   +template SDValue RISCVTargetLowering::getAddr<BlockAddressSDNode>(
>>>   +    BlockAddressSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
>>>   +template SDValue RISCVTargetLowering::getAddr<ConstantPoolSDNode>(
>>>   +    ConstantPoolSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
>>>   +template SDValue RISCVTargetLowering::getAddr<JumpTableSDNode>(
>>>   +    JumpTableSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
>>>   +
>>>    SDValue RISCVTargetLowering::lowerGlobalAddress(SDValue Op,
>>>                                                    SelectionDAG &DAG) const {
>>>      SDLoc DL(Op);
>>>
>>> fix the error for you?
>>
>> I'd be happy to review and approve a patch with this change but I think the fastest resolution to getting the bot back to green would be to revert and then recommit with this change added. The bot has been broken for over 24 hours so we would like to get it back online as soon as possible, thank you for your quick response. :)
>
> I've just committed the fix as 63ea7797dd5bb77cc7b2904e20a5b779d30d4f2d <https://reviews.llvm.org/rG63ea7797dd5bb77cc7b2904e20a5b779d30d4f2d>; strange how this exposes it but it's been lurking ready to break since 41454ab25645 <https://reviews.llvm.org/rG41454ab25645f28d53fe6db08ae41b9898142655> / D114950 <https://reviews.llvm.org/D114950>.

Thank you very much, the bots is green now :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121654/new/

https://reviews.llvm.org/D121654