[PATCH] D121822: [bootstrap] Allow passing options to sub-builds for all targets
Louis Dionne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 18 06:57:03 PDT 2022
ldionne added a comment.
In D121822#3390948 <https://reviews.llvm.org/D121822#3390948>, @phosek wrote:
> What I could come up with is `<project>_<option>_<target>` or `<project>_<target>_<option>`, so `LIBCXX_TEST_CONFIG_x86_64-linux-gnu=<config>` or `LIBCXX_x86_64-linux-gnu_TEST_CONFIG=<config>` but there might be other ways.
Hmm, I think I like `LIBCXX_TEST_CONFIG_x86_64-linux-gnu` best. It is closest to what CMake already does for various options like `CMAKE_<LANG>_FLAGS_<CONFIG>` (e.g. `CMAKE_CXX_FLAGS_Release`).
In that case, I will amend this patch so it accepts options in the form `LIBCXX_TEST_CONFIG` as-is, and we can work on moving the per-target option passthrough to the new convention separately.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121822/new/
https://reviews.llvm.org/D121822
More information about the llvm-commits
mailing list