[PATCH] D121995: [AMDGPU][MC][NFC] Refactored sendmsg(...) handling

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 18 04:47:13 PDT 2022


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUAsmUtils.cpp:24
+  {{"MSG_SAVEWAVE"},            ID_SAVEWAVE,
+                                     [](const MCSubtargetInfo &STI) {
+                                       return isVI(STI) || isGFX9Plus(STI);
----------------
I think it would be neater to define and use a new isGFX8GFX9 instead of having a lambda inside this table. (And the same for the hwreg table that you pushed already.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121995/new/

https://reviews.llvm.org/D121995



More information about the llvm-commits mailing list