[PATCH] D121768: [X86][tablgen] Auto-generate trivial fields and trivial interfaces for target features

[Tomas Matheson via Phabricator via llvm-commits]

tmatheson added a comment.

> Your method can not get rid of non-trivial feature like useAA, which has an virtual interface.

I gave an example above of exactly this:

  bool enablePostRAScheduler() const override { return usePostRAScheduler(); }



> In addition, as a LLVM backend developer, I often need to hack these interfaces to do some performance tuning or testing work, so the flexibility is quite important.

Could you be more specific? I can't imagine how consistent getter/field naming prevents performance or testing work.

Still seeing no justification for the added complexity of 2 new fields to SubtargetFeature, 3 new SubtargetFeature subclasses, in order to avoid a couple of function renames. We already have custom predicates.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121768/new/

https://reviews.llvm.org/D121768