[PATCH] D121978: [X86] Rename FeatureCMPXCHG8B/FeatureCMPXCHG16B to FeatureCX8/CX16 to match CPUID.

[Kan Shengchen via Phabricator via llvm-commits]

skan added inline comments.


================
Comment at: llvm/lib/Target/X86/X86Subtarget.h:717-719
+    // CX16 is just the CPUID bit, the instruction also requires 64-bit mode.
+    return HasCX16 && is64Bit();
+  }
----------------
I have a little concern about the name:
1.  `CMPXCHG16B`<-> `CX16` One use abbreviation but the other not, a little confusing
2.  `useCMPXCHG16B` is not so reasonable, the function is used to check if we //could// use CX16

I'm afraid adding `useCMPXCHG16B` would make `hasCX16` useless.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121978/new/

https://reviews.llvm.org/D121978