[PATCH] D121571: [TableGen] X86 mnemonic tables backend

[Amir Ayupov via Phabricator via llvm-commits]

Amir marked an inline comment as done.
Amir added inline comments.


================
Comment at: llvm/utils/TableGen/X86MnemonicTables.cpp:73
+    // Replace it with "CC".
+    if (Mnemonic.find("${cond}") != StringRef::npos) {
+      Mnemonic = Mnemonic.take_until([](char C) { return C == '$'; });
----------------
skan wrote:
> We could use StringRef::contains, but it's a minor issue...
The result of `find` is used later to extract the mnemonic part, so I'm keeping it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121571/new/

https://reviews.llvm.org/D121571