[PATCH] D121898: [Verifier] Verify parameter alignment.

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 23:32:47 PDT 2022


skan added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:3160
+    Align ABIAlign = DL.getABITypeAlign(Ty);
+    // ArgFlagsTy::MemAlign only have 4 bits for alignment, so the
+    // alignment size should not exceed 1 << 14, otherwise it can NOT
----------------
At least we need to add comments at ArgFlagsTy::MemAlign to say that we verify the width of bit field in Verify.cpp. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121898/new/

https://reviews.llvm.org/D121898



More information about the llvm-commits mailing list