[PATCH] D121768: Auto-generate trivial fields and trivial interfaces for target features

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86.td:104
                                       "Support 64-bit instructions">;
-def FeatureCMPXCHG16B : SubtargetFeature<"cx16", "HasCmpxchg16b", "true",
-                                      "64-bit with cmpxchg16b",
-                                      [FeatureCMPXCHG8B]>;
-def FeatureSSE4A   : SubtargetFeature<"sse4a", "HasSSE4A", "true",
+def FeatureCMPXCHG16B : TrivialFieldSubtargetFeature<"cx16", "HasCmpxchg16b", "true",
+                              "64-bit with cmpxchg16b (this is true for most "
----------------
craig.topper wrote:
> Doesn't hasCmpxchg16b() have non-trivial implementation?
Nevermind I see this uses TrivialFieldSubtargetFeature


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121768/new/

https://reviews.llvm.org/D121768