[PATCH] D121768: Auto-generate trivial fields and trivial interfaces for target features

Thu Mar 17 21:02:10 PDT 2022

skan added a comment.

In D121768#3391208 <https://reviews.llvm.org/D121768#3391208>, @craig.topper wrote:

> The cmov mess is because SSE and 64-bit odegen assumes cmov exists. We couldn’t make 64-bit or SSE imply cmov feature or -mattr=-cmov would disable SSE or 64bit which is just completely broken. Thus the OR that ignores attempts to disable cmov.

Thank you for the explanation, craig! Then I think it's important to have the flexibility to customize the interface, at least for now.  Similar interfaces also exist in AMDGPU target.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121768/new/

https://reviews.llvm.org/D121768