[PATCH] D120906: [ARM][AArch64] generate subtarget feature flags [NFC]

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 19:44:40 PDT 2022


skan added a comment.

In summary, this solution is good for ARM, but is not generic enough. We have to deprecate some customized interfaces and find other workarounds for X86 and AMDGPU w/ this method.
D121768 <https://reviews.llvm.org/D121768> provides a more flexible approach to allow developer customize the fields and interfaces,  and handle the descriptions of features in a better way. Could we consider applying D121768 <https://reviews.llvm.org/D121768> first and then reducing hand-written ARM codes in this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120906/new/

https://reviews.llvm.org/D120906



More information about the llvm-commits mailing list