[PATCH] D121974: Correct and complete dependency sets after 74b411d38c48513a125e67e049aca55452b9e855
Sterling Augustine via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 17 19:34:20 PDT 2022
saugustine created this revision.
Herald added a project: All.
saugustine requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Prior to this change the __support_cpp_array_ref target's only dependency was libc_root.
but it #includes "TypeTraits.h" and Array.h for that matter.
These dependencies matter when building in distributed build systems and the relevant
files must be know for the distributed build to ship them to the executor.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D121974
Files:
utils/bazel/llvm-project-overlay/libc/BUILD.bazel
Index: utils/bazel/llvm-project-overlay/libc/BUILD.bazel
===================================================================
--- utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -43,7 +43,11 @@
cc_library(
name = "__support_cpp_array_ref",
hdrs = ["src/__support/CPP/ArrayRef.h",],
- deps = [":libc_root"],
+ deps = [
+ ":__support_cpp_array",
+ ":__support_cpp_type_traits",
+ ":libc_root",
+ ],
)
cc_library(
@@ -87,7 +91,10 @@
cc_library(
name = "__support_cpp_utility",
hdrs = ["src/__support/CPP/Utility.h",],
- deps = [":libc_root"],
+ deps = [
+ ":__support_cpp_type_traits",
+ ":libc_root",
+ ],
)
cc_library(
@@ -99,7 +106,10 @@
cc_library(
name = "__support_cpp_atomic",
hdrs = ["src/__support/CPP/atomic.h",],
- deps = [":libc_root"],
+ deps = [
+ ":__support_cpp_type_traits",
+ ":libc_root",
+ ],
)
cc_library(
@@ -179,6 +189,8 @@
hdrs = sqrt_hdrs,
deps = [
":__support_common",
+ ":__support_cpp_bit",
+ ":__support_cpp_type_traits",
":__support_fputil",
":libc_root",
],
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121974.416375.patch
Type: text/x-patch
Size: 1221 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220318/5d4a8dcc/attachment.bin>
More information about the llvm-commits
mailing list