[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

Volodymyr Sapsai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 19:13:24 PDT 2022


vsapsai added a comment.

I don't know how "intsafe.h" looks like and how it is involved with the modules (it's not in winsdk.modulemap as far as I can tell). My immediate guess would be that "intsafe.h" doesn't include all the headers that are supposed to provide necessary macros. And if "intsafe.h" is in a separate module, for the code

  #define SOME_MACRO 1
  #include "intsafe.h"

"intsafe.h" won't see `SOME_MACRO`. That's how it can end up with different macro expansions. But that is just a guess (that can be waay wrong) and you could have checked this scenario already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121497/new/

https://reviews.llvm.org/D121497



More information about the llvm-commits mailing list