[PATCH] D121571: [TableGen] X86 mnemonic tables backend

[Kan Shengchen via Phabricator via llvm-commits]

skan accepted this revision.
skan added a comment.
This revision is now accepted and ready to land.

Thanks! LGTM generally.



================
Comment at: llvm/utils/TableGen/X86MnemonicTables.cpp:73
+    // Replace it with "CC".
+    if (Mnemonic.find("${cond}") != StringRef::npos) {
+      Mnemonic = Mnemonic.take_until([](char C) { return C == '$'; });
----------------
We could use StringRef::contains, but it's a minor issue...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121571/new/

https://reviews.llvm.org/D121571