[PATCH] D121654: [RISCV] Ensure PseudoLA* can be hoisted

Thu Mar 17 17:53:27 PDT 2022

kamaub added a comment.

In D121654#3390888 <https://reviews.llvm.org/D121654#3390888>, @jrtc27 wrote:

> In D121654#3390865 <https://reviews.llvm.org/D121654#3390865>, @kamaub wrote:
>
>> I have confirmed that this patch cause a miscompile on our sanitizer-ppc64be-linux #4255 <https://lab.llvm.org/buildbot/#/builders/18/builds/4255> bot, please investigate and fix this as soon as possible, thank you.
>
> The log says:
>
>   ../../../../lib/libLLVMRISCVCodeGen.a(RISCVISelDAGToDAG.cpp.o): In function `selectImm(llvm::SelectionDAG*, llvm::SDLoc const&, llvm::MVT, long, llvm::RISCVSubtarget const&)':
>   RISCVISelDAGToDAG.cpp:(.text._ZL9selectImmPN4llvm12SelectionDAGERKNS_5SDLocENS_3MVTElRKNS_14RISCVSubtargetE+0x3d8): undefined reference to `llvm::SDValue llvm::RISCVTargetLowering::getAddr<llvm::ConstantPoolSDNode>(llvm::ConstantPoolSDNode*, llvm::SelectionDAG&, bool) const'
>   collect2: error: ld returned 1 exit status
>
> Other buildbots are totally fine, as are my local builds. I really do not see how on earth _this_ change can cause the function I'm editing to no longer exist, unless the host toolchain is just broken.

I thought it was very strange as well, which is why I took so long to report it but the only thing that fixes the error is to revert the changeset.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121654/new/

https://reviews.llvm.org/D121654