[PATCH] D121953: [NewPM] Don't skip SCCs not in current RefSCC

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 16:39:57 PDT 2022


asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.

As discussed offline, the potential issue with this change is whether we encounter a pathological case in the "opposite direction".

Seeing how so far we have a concrete case where the current traversal order leads to the compile time explosion, and the benchmark in the compiler tracker also benefits from the change, I'm in favor of moving forward with the change and revisit if we encounter a benchmark exhibiting the high compile times after this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121953/new/

https://reviews.llvm.org/D121953



More information about the llvm-commits mailing list