[PATCH] D121849: [scudo][NFC] Rename local variables to avoid shadowing class members

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 12:20:43 PDT 2022


vitalybuka added a comment.

In D121849#3389831 <https://reviews.llvm.org/D121849#3389831>, @ddcc wrote:

> That's fair, we're building the standalone version out-of-tree with `-Weverything -Werror` among other things in our build system, which is why I've been seeing more warnings. Not sure if anything needs to be done then for the in-tree standalone build, since `-Wall` isn't documented to include `-Wshadow`?

I am not sure it's practical to enforce such rules on dependencies.
Can you use -isystem to include SCUDO to avoid warnings there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121849/new/

https://reviews.llvm.org/D121849



More information about the llvm-commits mailing list