[PATCH] D121714: [VP] fm flag transfer to SDNodes [VE] VVP_FMA fusion

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/VE/CMakeLists.txt:30
   VVPISelLowering.cpp
+  VVPCombine.cpp
 
----------------
Should this be alphabetized before VVPISelLowering?


================
Comment at: llvm/lib/Target/VE/VVPCombine.cpp:29
+  auto MulIdx = match_SomeOperand(Root, VEISD::VVP_FMUL, [](SDValue Op) {
+    return Op->hasOneUse() && Op->getFlags().hasAllowContract();
+  });
----------------
Do you need to check that the FADD is contractable too? I think that's what DAGCombiner.cpp does but the different ways of specifiying fast math make it hard to be sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121714/new/

https://reviews.llvm.org/D121714