[PATCH] D121857: [scudo] Don't assume preprocessor macro is defined

Dominic Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 10:21:52 PDT 2022


ddcc added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/platform.h:40
 
-#if __LP64__
 #define SCUDO_WORDSIZE 64U
----------------
vitalybuka wrote:
> isn't this evaluates to 0 if not defined?
Yes, but it emits a warning under `-Wundef`, and it's only ever supposed to be defined with value 1, so it's better to just check whether it's defined.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121857/new/

https://reviews.llvm.org/D121857



More information about the llvm-commits mailing list