[PATCH] D121862: [ProfSampleLoader] When disable-sample-loader-inlining is true, merge profiles of inlined instances to outlining versions.

[David Li via Phabricator via llvm-commits]

davidxl added a comment.

In D121862#3389598 <https://reviews.llvm.org/D121862#3389598>, @wenlei wrote:

>> related effort is kazu@ is doing analysis on context similarity analysis to try to tune down the sample loader inlining.
>
> Curious to hear more about this. Is tuning down sample loader inlining for performance or something else (e.g. compile time)? The problem of SCC inliner being bottom-up makes it less selective, which is a disadvantage comparing to early top-down inlining, so we were actually hoping to move more inlining from SCC to sample loader. Or are you shifting inlining to new ModuleInliner?

Re SCC inlining, yes -- kazu's prologue/epilogue based cost analysis won't work well it either -- so yes eventually more sophisticated analysis will rely on moduleinliner.  Working set based analysis I mentioned a while back ago is another candidate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121862/new/

https://reviews.llvm.org/D121862