[PATCH] D121566: Load pass plugins during option processing, so that plugin options are registered and live.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 09:23:09 PDT 2022


Meinersbur added inline comments.


================
Comment at: polly/test/lit.site.cfg.in:29-33
+commonOpts = ( ' -polly-process-unprofitable '
+             + ' -polly-remarks-minimal '
+             + ' -polly-use-llvm-names '
+             + ' -polly-import-jscop-dir=%S '
+             + ' -polly-codegen-verify ')
----------------
Parens are unnecessary here


================
Comment at: polly/test/lit.site.cfg.in:49-50
 else:
-    config.substitutions.append(('%loadPolly', ''
-                                 + ' -polly-process-unprofitable '
-                                 + ' -polly-remarks-minimal '
-                                 + ' -polly-use-llvm-names '
-                                 + ' -polly-import-jscop-dir=%S '
-                                 + ' -polly-codegen-verify '
-                                 ))
+    config.substitutions.append(('%loadPolly', '' + commonOpts ))
+    config.substitutions.append(('%loadNPMPolly', '' + commonOpts ))
+
----------------
Preprending empty string does nothing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121566/new/

https://reviews.llvm.org/D121566



More information about the llvm-commits mailing list