[PATCH] D121914: [AMDGPU] Stop using getMinimalPhysRegClass in LowerFormalArguments

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 07:52:31 PDT 2022


foad created this revision.
foad added reviewers: arsenm, vangthao, rampitec, Joe_Nash.
Herald added subscribers: kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
Herald added a project: All.
foad requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

NFCI. The motivation for this is avoid problems in future if we add new
classes containing only a subset of all VGPRs, or a subset of all SGPRs.
getMinimalPhysRegClass would favour these smaller classes, which is not
what we want here.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D121914

Files:
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp


Index: llvm/lib/Target/AMDGPU/SIISelLowering.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/SIISelLowering.cpp
+++ llvm/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -2548,7 +2548,9 @@
     assert(VA.isRegLoc() && "Parameter must be in a register!");
 
     Register Reg = VA.getLocReg();
-    const TargetRegisterClass *RC = TRI->getMinimalPhysRegClass(Reg, VT);
+    const TargetRegisterClass *RC = AMDGPU::SGPR_32RegClass.contains(Reg)
+                                        ? &AMDGPU::SGPR_32RegClass
+                                        : &AMDGPU::VGPR_32RegClass;
     EVT ValVT = VA.getValVT();
 
     Reg = MF.addLiveIn(Reg, RC);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121914.416178.patch
Type: text/x-patch
Size: 690 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220317/f755593b/attachment.bin>


More information about the llvm-commits mailing list