[PATCH] D121768: [tablgen][X86] Auto-generate fields and trival interace for target features

Tomas Matheson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 02:50:30 PDT 2022


tmatheson added a comment.

This looks remarkably similar to an ARM/AArch64 patch I've had up for a couple of weeks: D120906 <https://reviews.llvm.org/D120906>

The main differences seem to be:

1. I use a more general GET_SUBTARGETINFO_MACRO macro that can be expanded for other uses going forwards, rather than emitting the various bits of C++ directly.
2. This patch makes a distinction between trivial/nontrivial members, why is this necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121768/new/

https://reviews.llvm.org/D121768



More information about the llvm-commits mailing list