[PATCH] D121571: [TableGen] X86 mnemonic tables backend

[Amir Ayupov via Phabricator via llvm-commits]

Amir marked an inline comment as done.
Amir added inline comments.


================
Comment at: llvm/utils/TableGen/X86MnemonicTables.cpp:69
+    // \t
+    StringRef Mnemonic =
+        StringRef(AsmString).take_until([](char C) { return C == '\t'; });
----------------
skan wrote:
> I'm afraid using `StringRef` here is not safe, `AsmString` is destoryed after each iteration.
You're right. Moved the CC printing down to the emission steps.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121571/new/

https://reviews.llvm.org/D121571