[PATCH] D116072: [X86] GLC: Break false dependency for dest register for several instructions.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86.td:583
+                               "HasCMULFalseDeps", "true",
+                               "CMUL has a false dependency on dest register">;
+
----------------
Probably shouldn't overly shorten instruction names in documentation that goes into user facing help text.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:5785
+      return;
+    // These instructions are all floating point domain, so vpxord is the best
+    // choice.
----------------
gpei wrote:
> craig.topper wrote:
> > This doesn't make sense. VPXORD is an integer instruction.
> Yes, I copied the comments above. There is no VPXORPSZ128rr, is it acceptable I only delete my comments?
That's because VP means integer. There's a VXORPSZ128rr, but it requires AVX512DQ. So using VPXORD is probably best.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116072/new/

https://reviews.llvm.org/D116072