[PATCH] D121600: [Codegen][X86][XCore] Allow meta instruction to be target dependent
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 16 19:12:03 PDT 2022
craig.topper added a comment.
In D121600#3388072 <https://reviews.llvm.org/D121600#3388072>, @skan wrote:
> In D121600#3388065 <https://reviews.llvm.org/D121600#3388065>, @craig.topper wrote:
>
>> If you’re fixing a bug shouldn’t there be a test?
>
> We have a unit test in MachineMetadata.cpp.
Is that test doing anything more than checking that isMetaInstruction returns true for the test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121600/new/
https://reviews.llvm.org/D121600
More information about the llvm-commits
mailing list