[PATCH] D121848: [scudo] Remove unused header includes and fix declarations

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 17:32:49 PDT 2022


vitalybuka added a comment.

Can you please split #include cleanup and the rest?



================
Comment at: compiler-rt/lib/scudo/standalone/string_utils.cpp:13
 #include <stdarg.h>
-#include <string.h>
 
----------------
there is memset on :50


================
Comment at: compiler-rt/lib/scudo/standalone/vector.h:14
 
-#include <string.h>
-
----------------
it's used on :46


================
Comment at: compiler-rt/lib/scudo/standalone/wrappers_c.h:22
 
+extern "C" void malloc_postinit();
+extern scudo::Allocator<scudo::Config, malloc_postinit> Allocator;
----------------
Why do we need this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121848/new/

https://reviews.llvm.org/D121848



More information about the llvm-commits mailing list