[PATCH] D121571: [TableGen] X86 mnemonic tables backend

[Amir Ayupov via Phabricator via llvm-commits]

Amir added inline comments.


================
Comment at: llvm/utils/TableGen/X86MnemonicTables.cpp:44
+    Record *Def = I->TheDef;
+    if (!Def->isSubClassOf("X86Inst") || // Filter non-X86 instructions
+        // Skip pseudo instructions as they may contain non-alnum characters in
----------------
skan wrote:
> Need to check the `Form` is not neither `Pseudo` or  `PrefixByte`.
I decided to reuse `X86Disassembler::RecognizableInstr` as it parses almost all the necessary fields, specifically `Form`. Otherwise I'd have to copy/paste `byteFromBitsInit` Record field parsing function which I didn't want.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121571/new/

https://reviews.llvm.org/D121571