[PATCH] D120265: AMDGPU: Use the implicit kernargs for code object version 5

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIDefines.h:784
+// Implicit kernel argument offset for code object version 5.
+enum ImplicitKernargOffset : unsigned {
+  HOSTCALL_PTR_OFFSET = 80,
----------------
cfang wrote:
> arsenm wrote:
> > Add a COV5 suffix? Probably should also wrap in a namespace
> Add COV5 suffix, and wrap in a namespace of ImplicitArg. Rename the type to
> Offset. So it is of AMDGPU::ImplicitArg::Offset type.  
I meant suffix on the enum itself, not on each individual field


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120265/new/

https://reviews.llvm.org/D120265