[PATCH] D121696: [AMDGPU][MC][NFC] Refactored custom operands handling
Dmitry Preobrazhensky via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 16 14:55:39 PDT 2022
dp added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUAsmUtils.cpp:107
+ {{"HW_REG_HW_ID"}, ID_HW_ID1, isGFX10},
};
+// NOLINTEND
----------------
mehdi_amini wrote:
> This does not build with gcc5:
> ```
> llvm/lib/Target/AMDGPU/Utils/AMDGPUAsmUtils.cpp:107:1: error: could not convert '(const char*)""' from 'const char*' to 'llvm::StringLiteral'
> };
> ^
> ```
>
> Can you have a look?
Sure. I’ll try to fix it tomorrow.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121696/new/
https://reviews.llvm.org/D121696
More information about the llvm-commits
mailing list