[PATCH] D121566: Load pass plugins during option processing, so that plugin options are registered and live.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

In D121566#3386778 <https://reviews.llvm.org/D121566#3386778>, @w2yehia wrote:

>> If you really want that error, I suggest to introduce a new %loadPolly_NPM (or similar name) that loads the NPM plugin, and %loadPolly to only load the legacy PM plugin.
>
> %loadPolly is currently used in all polly testcases. Does this require touching every polly testcase that uses %loadPolly? Is there an easy way to tell (by inspection) if a testcase is calling the NPM passes of polly?

`%loadPolly` would only need to be replaced with `%loadPolly_NPM` in test cases using the NPM. There are not that many yet. You get a list of test cases using the NPM by removing `-load-pass-plugin` from `%loadPolly` and run `ninja check-polly-tests` (using `LLVM_POLLY_LINK_INTO_TOOLS=OFF`). Those are also the RUN-lines that would need `%loadPolly_NPM` instead of `%loadPolly`. Alternatively, grep for RUN-lines with `-passes=` option.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121566/new/

https://reviews.llvm.org/D121566