[PATCH] D121354: [SLP] Fix lookahead operand reordering for splat loads.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 08:39:56 PDT 2022


RKSimon added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:1057
+                                 VectorType *SubTp = nullptr,
+                                 bool IsLoad = false) const;
 
----------------
ABataev wrote:
> I belive better to pass the instruction here, just like in other functions. And then do the analysis of this instruction, if it was passed.
Passing ArrayRef<const Value *> Args like we do for arith op makes sense here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121354/new/

https://reviews.llvm.org/D121354



More information about the llvm-commits mailing list