[PATCH] D121452: [VPlan] Avoid scalarization for scalable vectors.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/scalable-avoid-scalarization.ll:80
+
+L.LB19_336:                                       ; preds = %L.LB19_336, %L.entry
+  %indvars.iv = phi i32 [ %indvars.iv.next, %L.LB19_336 ], [ %idx, %L.entry ]
----------------
Might be good to clean up the basic block names here a bit.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/scalable-avoid-scalarization.ll:5
+
+; CHECK-NOT: Assertion {{.*}} "Can't scalarize a scalable vector"' failed
+
----------------
sdesmalen wrote:
> malharJ wrote:
> > fhahn wrote:
> > > Does this fail without the change or does this need `2>&1`?
> > this test will fail without this change .. I dont think 2>&1 is needed.
> I'd actually prefer this test to check the output of LoopVectorize so that we can make sure the output is as expected, as opposed to checking for the absence of a failure.
> @malharJ You can probably use the update_test_checks script to generate CHECK lines for the output.
> this test will fail without this change .. I dont think 2>&1 is needed.

Oh right, it originally failed due to the crash, not the mismatch. The current checks should be sufficient now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121452/new/

https://reviews.llvm.org/D121452