[PATCH] D121801: [llmv-pdbutil] Replace ExitOnError with explicit error handling.

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 06:48:40 PDT 2022


CarlosAlbertoEnciso created this revision.
CarlosAlbertoEnciso added reviewers: rnk, zequanwu, aganea, probinson, zturner.
CarlosAlbertoEnciso added a project: LLVM.
Herald added a project: All.
CarlosAlbertoEnciso requested review of this revision.
Herald added a subscriber: llvm-commits.

[llmv-pdbutil] Replace ExitOnError with explicit error handling.

At Sony we are developing llvm-dva

https://lists.llvm.org/pipermail/llvm-dev/2020-August/144174.html

For its PDB support, it requires functionality already present
in llvm-pdbutil.

We intend to move that functionaly into the PDB library to be
shared by both tools. That change will be done in 2 steps, that
will be submitted as 2 patches:

(1) Replace 'ExitOnError' with explicit error handling.
(2) Move the intended shared code to the PDB library.

This patch is for step (1).

As 'ExitOnError' is intended to be used only in tool code, replace
all occurrences in the code that will be moved to the PDB library
with explicit error handling.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D121801

Files:
  llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp
  llvm/tools/llvm-pdbutil/InputFile.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121801.415804.patch
Type: text/x-patch
Size: 17060 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220316/46c2d779/attachment.bin>


More information about the llvm-commits mailing list