[PATCH] D121768: [tablgen] Auto-generate fields & interfaces for target features

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 21:07:14 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/utils/TableGen/SubtargetEmitter.cpp:1743
+      AttrVals.insert({Attribute, Value});
+    if (Attrs.find(Attribute) != Attrs.end())
+      continue;
----------------
You can do

```
if (!Attrs.insert(Attribute).second)
  continue;
```

instead of calling find and insert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121768/new/

https://reviews.llvm.org/D121768



More information about the llvm-commits mailing list