[PATCH] D121714: [VP] fm flag transfer to SDNodes [VE] VVP_FMA fusion

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 18:33:54 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7530
+      NodeFlags.setNoFPExcept(true); // TODO: Constrained VP
+      Result->setFlags(NodeFlags);
+    }
----------------
Is this correct if the getNode call CSEs with an existing node? Should probably pass the flags to getNode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121714/new/

https://reviews.llvm.org/D121714



More information about the llvm-commits mailing list