[PATCH] D121713: [OpenMP] Initial parsing/sema for the 'omp teams loop' construct

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:4279-4285
+    // TODO: 'loop' may require additional parameters depending on the binding.
+    // Treat similar to OMPD_simd/OMPD_for for now.
+    Sema::CapturedParamNameType Params[] = {
+        std::make_pair(StringRef(), QualType()) // __context with shared vars
+    };
+    ActOnCapturedRegionStart(DSAStack->getConstructLoc(), CurScope, CR_OpenMP,
+                             Params, /*OpenMPCaptureLevel=*/1);
----------------
mikerice wrote:
> ABataev wrote:
> > Copy/paste? The binding here is known aready, no?
> Since I didn't write codegen for this I don't really know what this should be.  The codegen I've seen seems to produce different code depending on the binding in this case, so I left an unknown region to be replaced by the right code when someone does the codegen.
> 
> I'll do whatever you want here.  What do you think it should be?
I thought the binding region here is teams, so only OMPD_teams should be enough, without extra OMPD_unknown.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121713/new/

https://reviews.llvm.org/D121713