[PATCH] D91577: [lld][WebAssembly] Add --unresolved-symbols=import-dynamic

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 15:10:42 PDT 2022


sbc100 added inline comments.


================
Comment at: lld/docs/WebAssembly.rst:97
+
+     Like import-undefined but also import the addresses of unresolved data
+     symbols.  This puts limitations on the type of relocations that are allowed
----------------
dschuff wrote:
> this is now slightly confusing since --unresolved symbols is no longer completely orthogonal to --import-undefined? Probably at least the doc for --import-undefined should go just above --unresolved-symbols
I went back and forth between adding `--import-dynamic` and `--unresolved-symbols=import-dynamic`.   In the end I think this is more clear since unlike `--import-undefined` this new option effects all undefined symbols.

This option is currently behind the `--experimental-pic` flag so revisiting this decision in the future is still possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91577/new/

https://reviews.llvm.org/D91577



More information about the llvm-commits mailing list