[PATCH] D120626: [ELF] Move section assignment from initializeSymbols to postParse

[Haowei Wu via Phabricator via llvm-commits]

haowei added a comment.

We are seeing build failures in cmake config step for the clang runtime builds after this patch. Example of error messages:

  [3945/4056] Performing configure step for 'runtimes-i386-unknown-linux-gnu'
  -- The C compiler identification is Clang 15.0.0
  -- The CXX compiler identification is Clang 15.0.0
  -- The ASM compiler identification is Clang with GNU-like command-line
  -- Found assembler: /mnt/nvme_sec/SRC/llvm-project/build-repro/./bin/clang
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - failed
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - failed
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done
  -- Could NOT find ZLIB (missing: ZLIB_LIBRARY) (found version "1.2.11")
  -- Found LibXml2: /usr/lib/x86_64-linux-gnu/libxml2.so (found version "2.9.12")
  -- Could NOT find ZLIB (missing: ZLIB_LIBRARY) (found version "1.2.11")
  -- Performing Test LLVM_RUNTIMES_LINKING_WORKS
  -- Performing Test LLVM_RUNTIMES_LINKING_WORKS - Failed
  -- Performing Test LLVM_RUNTIMES_SUPPORT_UNWINDLIB_NONE_FLAG
  -- Performing Test LLVM_RUNTIMES_SUPPORT_UNWINDLIB_NONE_FLAG - Failed
  -- Performing Test LLVM_RUNTIMES_SUPPORT_NOSTDLIBXX_FLAG
  -- Performing Test LLVM_RUNTIMES_SUPPORT_NOSTDLIBXX_FLAG - Failed
  -- Performing Test LLVM_RUNTIMES_SUPPORT_NOSTDINCXX_FLAG
  -- Performing Test LLVM_RUNTIMES_SUPPORT_NOSTDINCXX_FLAG - Failed
  CMake Warning (dev) at /usr/share/cmake-3.22/Modules/GNUInstallDirs.cmake:239 (message):
    Unable to determine default CMAKE_INSTALL_LIBDIR directory because no
    target architecture is known.  Please enable at least one language before
    including GNUInstallDirs.
  Call Stack (most recent call first):
    /mnt/nvme_sec/SRC/llvm-project/llvm/cmake/modules/AddLLVM.cmake:1 (include)
    CMakeLists.txt:126 (include)
  This warning is for project developers.  Use -Wno-dev to suppress it.
  
  -- Linker detection: unknown
  -- Performing Test CXX_SUPPORTS_CUSTOM_LINKER
  -- Performing Test CXX_SUPPORTS_CUSTOM_LINKER - Failed
  CMake Error at /mnt/nvme_sec/SRC/llvm-project/llvm/cmake/modules/HandleLLVMOptions.cmake:308 (message):
    Host compiler does not support '-fuse-ld=lld'
  Call Stack (most recent call first):
    CMakeLists.txt:127 (include)

Example of the build failure on the bots: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8819676041146779809/+/u/clang/build/stdout
This breakage was masked by another breakage caused by e049a87f04cff8e81b4177097a6b2fdf37c7b148 <https://reviews.llvm.org/rGe049a87f04cff8e81b4177097a6b2fdf37c7b148> so it took us a bit while to figure out. We locally verified 0c3156bd43842d8f0ea54bea3fea628e8fee93d2 <https://reviews.llvm.org/rG0c3156bd43842d8f0ea54bea3fea628e8fee93d2> (1 patch before) will pass the build while c30e6447c0225f675773d07f2b6d4e3c2b962155 <https://reviews.llvm.org/rGc30e6447c0225f675773d07f2b6d4e3c2b962155> (this patch) will fall with the error message above.

Could you take a look? If it takes a bit long time to investigate, could you revert this change first please?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120626/new/

https://reviews.llvm.org/D120626