[PATCH] D121720: [Debuginfod] Don't depend on Content-Length.

[Noah Shutty via Phabricator via llvm-commits]

noajshu added a comment.

Thanks for implementing this! I think it mostly looks good and should have the side benefit of saving memory for large downloads.

I hesitate to endorse the new `HTTPClient::responseCode()` method. It seems more intuitive to me that the HTTP response code should be stored inside the request object (this was the previous design). This is because there is one response code affiliated with each request. Indeed, an application can use the same `HTTPClient` from multiple threads; this new design prevents us from learning the individual response codes for concurrent requests.

If you agree, I think you can just un-delete the `handleResponseCode` declaration + definition and its invocation inside `perform()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121720/new/

https://reviews.llvm.org/D121720