[PATCH] D121720: [Debuginfod] Don't depend on Content-Length.

[Daniel Thornburgh via Phabricator via llvm-commits]

mysterymath marked an inline comment as done.
mysterymath added inline comments.


================
Comment at: llvm/include/llvm/Debuginfod/HTTPClient.h:11
 /// This file contains the declarations of the HTTPClient, HTTPMethod,
 /// HTTPResponseHandler, and BufferedHTTPResponseHandler classes, as well as
 /// the HTTPResponseBuffer and HTTPRequest structs.
----------------
noajshu wrote:
> 
Made these comments a bit more abstract.


================
Comment at: llvm/lib/Debuginfod/Debuginfod.cpp:122
+/// file is only created if a 200 OK status is observed.
+class StreamedHTTPResponseHandler final : public HTTPResponseHandler {
+  using CreateStreamFn =
----------------
noajshu wrote:
> Just out of curiousity, why use `final`? Is this a style convention or is there some performance impact?
No reason, just a copy/pasted oversight from BufferedHTTPResponseHandler. Removed for parsimony.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121720/new/

https://reviews.llvm.org/D121720