[PATCH] D121381: [MemorySSA] Support lazy use optimization

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 13:08:17 PDT 2022


asbirlea added a comment.

LGTM for this patch on the impact side, testing looks good.

+1 on improving documentation for future uses, to include that by default uses are no longer optimized. Also rename the new method to `ensureOptimizedUses()` per @reames's suggestion.
(docs can be landed separately as long as they come shortly after)

On the impact for the EarlyCSE follow-up I'm seeing a couple of small regressions in fdo configuration that I would not block on. I'd go with landing the EarlyCSE change separately from this and evaluate if increasing the cap makes sense or not based on if other folks notice any performance impact from the change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121381/new/

https://reviews.llvm.org/D121381



More information about the llvm-commits mailing list