[PATCH] D121727: [NVPTX] Integrate ptxas to LIT tests

[Andrew Savonichev via Phabricator via llvm-commits]

asavonic added a comment.

In D121727#3383453 <https://reviews.llvm.org/D121727#3383453>, @tra wrote:

> Substituting `true` may not always work. It's OK if we only need pass/fail result from ptxas, but we may want to check ptxas output, too.
>
> Can we make `ptxas` a feature instead? The tests that need it would use `REQUIRES: ptxas` and would be guaranteed to have ptxas available.
> It may also need to be versioned, too. Some tests may require recent enough version of ptxas in order to work (e.g. we may want to use it to test new instructions that an older ptxas may not understand).

We should probably have both: substitution to `true` works for *all* existing tests where can use ptxas as a sanity check, and a feature allows us to write tests for machine code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121727/new/

https://reviews.llvm.org/D121727