[PATCH] D121722: [AlwaysInliner] Check inliner errors even without assserts

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 12:05:28 PDT 2022


nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.

Either inlining always succeeds and we assert, or inlining can fail and we should never assert.

I //do// think that it can fail, and you should be able to add a test for it. There's a bunch of checks at the start of InlineFunction that should be usable for that purpose, e.g. a personality function mismatch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121722/new/

https://reviews.llvm.org/D121722



More information about the llvm-commits mailing list