[PATCH] D121420: [lld][WebAssembly] Take advantage of extended const expression when available

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 11:43:48 PDT 2022


sbc100 added inline comments.
Herald added a subscriber: asb.


================
Comment at: lld/wasm/SyntheticSections.h:277
 
   // Add an internal GOT entry global that corresponds to the given symbol.
   // Normally GOT entries are imported and assigned by the external dynamic
----------------
dschuff wrote:
> Does this comment need updating?
I think the comment is still accurate.  What has changed is that these globals might not need relocation.. but this comment doesn't touch on the relocation part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121420/new/

https://reviews.llvm.org/D121420



More information about the llvm-commits mailing list