[PATCH] D121719: [AMDGPU] Regen checks for no-remat-indirect-mov

Tue Mar 15 11:15:00 PDT 2022

Joe_Nash added a comment.

In D121719#3383198 <https://reviews.llvm.org/D121719#3383198>, @arsenm wrote:

> In D121719#3383189 <https://reviews.llvm.org/D121719#3383189>, @Joe_Nash wrote:
>
>> In D121719#3383148 <https://reviews.llvm.org/D121719#3383148>, @arsenm wrote:
>>
>>> In D121719#3383145 <https://reviews.llvm.org/D121719#3383145>, @Joe_Nash wrote:
>>>
>>>> @arsenm PTAL, I realize the commit message was misleading. It appears like something changed and the checks weren't regenerated. Could be related to @foad  patch cce93b339724a34928f0630fa8ed6b09b4ba753b <https://reviews.llvm.org/rGcce93b339724a34928f0630fa8ed6b09b4ba753b> , since that's when the 2nd check line was added.
>>>
>>> I'd guess this is related to update_mir_test_checks not understanding what to do when the output is identical between run lines
>>
>> Ok that makes sense, I both lines are actually identical. Thanks
>
> In that case you should comment out the second run line, regenerate, and re-add the second line. It's an annoying workaround. update_mir_test_checks should be fixed to behave like update_llc_test_checks where it commons individual functions with a shared prefix

Done 687d20de7ffc69dd4ecdb9808aeb6d3cffcf3871 <https://reviews.llvm.org/rG687d20de7ffc69dd4ecdb9808aeb6d3cffcf3871>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121719/new/

https://reviews.llvm.org/D121719