[PATCH] D121421: [VFS] Add print/dump to the whole FileSystem hierarchy

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of suggestions inline.



================
Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:321
+protected:
+  virtual void printImpl(raw_ostream &OS, PrintType Type,
+                         unsigned IndentLevel) const {
----------------
Maybe worth an explanation in the commit message why `print()`'s virtual behaviour is split out to `printImpl()`; up to you though.


================
Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:402
+  range overlays_range() { return llvm::reverse(FSList); }
+
+  const_range overlays_range() const { return llvm::reverse(FSList); }
----------------
For this const/non-const pair you might skip the blank link between them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121421/new/

https://reviews.llvm.org/D121421